-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated c-blosc
to commit 9dc93b1 and zstd
to v1.5.2
#200
Conversation
git-subtree-dir: src/c-blosc git-subtree-split: 9dc93b1de7c1ff6265d0ae554bd79077840849d8
The assembly code is only enabled under linux and macos and explicitly disabled otherwise. Tested also on Power9 and macos ARM. One issue may be for generic builds (manylinux, conda): This assembly code uses BMI2 instructions which are apparently available starting from Haswell Intel processors and Excavator AMD processors, so available since about 10 years. We can:
|
I added an env. var. Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I like the conservative approach concerning assembler code and windows...
If you know how to handle assembly code in build through |
From a quick look (I haven't tested anything), Visual Studio does not seems to support assembly code by default. |
This PR updates
c-blosc
to commit 9dc93b1 initially to fix macosuniversal2
build.It also updates
zstd
to v1.5.2 which includes a piece of x86_64 assembly code (that looks to work by passing it asextra_objects
to theExtension
s).This still needs testing on architecture different from x86_64.
closes #186