Added ARM64 support; Added build config with environment variables #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have access to an M1 either - maybe @ndevenish may be able to help out? |
|
FWIW |
|
Great! Thanks for the testing!
|
|
Ready for review. |
t20100
changed the title
t20100
changed the title
|
FYI, this has been released in v3.0.0 and pushed to pypi: https://pypi.org/project/hdf5plugin/ |
t20100
added a commit
to t20100/hdf5plugin
that referenced
this pull request
Sep 4, 2023
092190c38 Fix spelling errors (silx-kit#128) b241ca0d0 Fix the CMake multiconfig var and test and tools handling (silx-kit#127) 7b33e4f19 Fix some make output issues (silx-kit#126) 51d221848 Documentation fixes and fixes from testing 1.1.1 (silx-kit#125) 4ae30429c CMake: (fix) HDF5 1.14.0 (silx-kit#121) e1072ec5b Update Github actions (silx-kit#118) b021532ea Fix leak and consistify generic API with ZFP C API (silx-kit#117) 06408bb22 Enable CMake Testing (silx-kit#116) eb5440043 Fix version info in docs ad61dfa41 Revert "rework feat-cmake_tests CMake and replace scripts (silx-kit#111)" (silx-kit#115) 03b86413f rework feat-cmake_tests CMake and replace scripts (silx-kit#111) 08116fa9e Update README.md (silx-kit#114) a10bd7bdb Merge branch 'master' of github.com:LLNL/H5Z-ZFP 1660d94a4 Fix h5repack test (silx-kit#107) fd01bf1d7 mention generic interface 8d5ec2e74 Update docs (silx-kit#106) c76f847d9 Added new endianness test (silx-kit#102) 8acf8244b fix reading of byte-swapped input files (silx-kit#95) (silx-kit#101) 62ab4eb6d Minor code clean-up. (silx-kit#103) 60032f640 Bugfix/hdf5 1.14.0 (silx-kit#99) 8fad85d72 CMake: (fix) MPI parallel HDF5 1.14.0 (silx-kit#97) e81aec114 Don't flag a skipped test as a failed test. (silx-kit#94) git-subtree-dir: src/H5Z-ZFP git-subtree-split: 092190c38d5760b3212ce4d96cced767b90aa189
t20100
added a commit
to t20100/hdf5plugin
that referenced
this pull request
Jul 4, 2024
f466775 Merge pull request silx-kit#116 from ayzk/master1 bde9259 fix a bug when dimension is corrected in compression but not in decompression a92658e Merge pull request silx-kit#109 from vasole/master a5d6039 Restrict the scope only to windows without MINGW as already done. d0c7f6c Force static build of external libraries with MSVC 73065ab Remove gcc specific options git-subtree-dir: src/SZ git-subtree-split: f4667759ead6a902110e80ff838ccdfddbc8dcd7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should add support for M1 by disabling SSE2 and AVX2 on
arm64machines.It also adds env var to configure default build options (useful with
cibuildwheel)This is UNTESTED!