Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update h5grove snapshot following fix for complex256 numbers #1588

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Mar 13, 2024

Following silx-kit/h5grove#91, h5grove no longer responds with 500 errors when fetching complex256 datasets. I've upgraded h5grove on Bosquet, so I'm now updating the test snapshots here.

Note that h5grove also no longer casts the float32 real/imag parts of complex64 numbers to float64 when serializing to JSON.

We still have the issue that any float128 number that overflows the float64 range is cast to inf and serialised to JSON as null (cf. #641), which breaks the visualizations. The best way around this would be to fetch complex numbers as binary, but that's a problem for another day.

@axelboc axelboc requested a review from loichuder March 13, 2024 09:50
@axelboc axelboc merged commit 463baea into main Mar 13, 2024
8 checks passed
@axelboc axelboc deleted the complex256 branch March 13, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant