Document transforming selections and rendering SVG elements #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
axelboc
commented
Jan 16, 2023
axelboc
commented
axelboc
commented
Jan 16, 2023
loichuder
approved these changes
Jan 16, 2023
| fill-opacity: 0.2; | ||
| stroke: teal; | ||
| stroke-width: 2; | ||
| pointer-events: auto; |
There was a problem hiding this comment.
Note this blocks panning/zooming when hovering the rectangle
There was a problem hiding this comment.
Yep, we'll have to find a solution for this at some point...
| ]} | ||
| > | ||
| {(pt1, pt2, pt3, pt4, pt5, pt6) => ( | ||
| <SvgElement> |
There was a problem hiding this comment.
Question: it is possible to wrap several DataToHtml (e.g. one per shape) in a single SvgElement ?
There was a problem hiding this comment.
Nope, DataToHtml cannot be inside SvgElement since it requires access to the R3F context. SvgElement changes the renderer so we lose access to that context. You can have multiple SvgElement and wrap each of them with a DataToHtml, though. It's the same problem as with Html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.