Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Vector3 in all coordinate spaces #1341

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Use Vector3 in all coordinate spaces #1341

merged 1 commit into from
Jan 10, 2023

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jan 9, 2023 •
edited
Loading

Using Vector2 in HTML and data spaces is actually really inconvenient -- it was making it difficult to explore solutions for switching SelectionTool to HTML space. By using Vector3 in all three coordinate spaces, we can for instance use the Box abstraction in all three spaces without pain.

@axelboc axelboc requested a review from loichuder January 9, 2023 10:51
Base automatically changed from derived-transform to main January 9, 2023 12:53
@axelboc axelboc merged commit a64036e into main Jan 10, 2023
@axelboc axelboc deleted the vec3 branch January 10, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder