Fix selection change callback not called on first pointer move #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
force-pushed
the
selection-change
branch
from
cc6dd6d to
72a8bdf
Compare
axelboc
commented
Jan 5, 2023
| if (selection) { | ||
| // Previous selection was undefined and current selection is now defined => selection has started | ||
| if (!prevSelectionState?.selection) { | ||
| onSelectionStartRef.current?.(selection); |
There was a problem hiding this comment.
No return here, so onSelectionChange gets called.
loichuder
approved these changes
Jan 5, 2023
axelboc
force-pushed
the
selection-change
branch
from
72a8bdf to
90420ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor, subtle bug: consumers of
SelectionToolregistering anonSelectionChangecallback were not being notified of the first pointer move event.SelectionToolwas callingonSelectionStartbut notonSelectionChangeafter the first pointer move event. This is now corrected.