Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera utilities worldToHtml, htmlToWorld and htmlToData #1302

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Nov 28, 2022

We already had dataToHtml; I'm just adding the missing ones. This helps to extract some of the vector conversions and camera projections from the useCanvasEvents.

@axelboc axelboc requested a review from loichuder November 28, 2022 11:00
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

apps/storybook/src/Utilities.stories.mdx Show resolved Hide resolved
packages/lib/src/vis/utils.ts Show resolved Hide resolved
packages/lib/src/vis/utils.ts Show resolved Hide resolved
@axelboc axelboc force-pushed the transform-selection branch from 9b7aee3 to 6f23f8e Compare November 28, 2022 14:21
Base automatically changed from transform-selection to main November 28, 2022 14:32
@axelboc axelboc merged commit 2dee60d into main Nov 28, 2022
@axelboc axelboc deleted the camera-utils branch November 28, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants