Allow transforming selection in SelectionTool
#1301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transformSelection
toSelectionTool
, which allows transforming the selection before it gets passed toonSelectionChange
,onSelectionEnd
and thechildren
render prop. This cleans up the code ofAxialSelectionTool
quite a bit, since we no longer have to monkey-patch those three props in order to turn the user's selection into an axial selection.AxialSelectionTool
transforms the user's selection into an axial selection. Instead of doingdata -> world -> data
, we now just doworld -> data
. See comments.Axis
type ('x' | 'y'
) into@h5web/shared
so I can re-use it everywhere. The name technically conflicts with ourAxis
component, but it doesn't seem to be a problem for now.