Replace visRatio
and layout
props with aspect
prop
#1284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1275
[VisCanvas]
PropvisRatio
is replaced with propaspect
, which follows matplotlib:'auto'
is equivalent to novisRatio
(i.e. the heatmap's'fill'
layout);'equal'
is equivalent to computingvisRatio
from the axis domains to obtain an orthonormal basis (i.e. the heatmap'scover
layout) -- so now, this ratio computation is performed internally byVisCanvas
;aspect
is anumber
, then it is used as the ratio directly (this is not used by the viewer; it's just for flexibility of the lib and consistency with matplotlib).[HeatmapVis, RgbVis]
Proplayout
is replaced with propaspect
, which is given sane defaults ('equal'
) and forwarded toVisCanvas
.I've also replaced the
layout
property in the config stores and toolbars with akeepRatio
property, since it is all we care about in the viewer.