FIX Avoid inferring model type #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Since Versioned->versions() results in an ArrayList, it triggers database queries. The database isn't always available when the schema is built (e.g. on deployment and CI environments). Context: silverstripe/silverstripe-graphql#388
unclecheese
force-pushed
the
pulls/avoid-queries-on-build
branch
from
782cea9
to
70e702a
Compare
|
Since this is an old draft, and I haven't seen instances of this being a problem in my time maintaining Silverstripe CMS, I'm going to close this. If someone can show me a recent case where this has been a problem, we can look into opening an issue and taking it from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Versioned->versions() results in an ArrayList, it triggers database queries.
The database isn't always available when the schema is built (e.g. on deployment and CI environments).
Relies on: silverstripe/silverstripe-graphql#395
Context: silverstripe/silverstripe-graphql#388
Tasks