-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH - Add 'Includes' condition option to EmailRecipientCondition #1275
ENH - Add 'Includes' condition option to EmailRecipientCondition #1275
Conversation
Can you please fill in the PR template information @sukhwinder-somar and run through the checklist? You can skip the CI is green as you can't trigger it. |
@michalkleiner - I have gone through the checklist and checked |
Thanks for doing that. Have you also read the points and the pages they link to before checking the checkboxes? For example the commit message doesn't specify the type of the change, the issue is not linked in the PR description. We don't want to discourage contributions, but helping us by ensuring high quality of the PRs can make the review and merge faster. |
Sure bud, I have gone through it, please let me know if you see anything else wrong in commit's heading or something else..... |
@GuySartorelli - Morning mate, I have changed the commit message as per direction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
@GuySartorelli - sweet, committed the suggested code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Description
Manual testing steps
Issues
Pull request checklist