ENH Add generic types (#222)

silverstripe · Jan 18, 2024 · b78b1af · b78b1af
1 parent bc5189b
commit b78b1af
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 2 deletions.
diff --git a/src/Controllers/ShareDraftController.php b/src/Controllers/ShareDraftController.php
@@ -81,7 +81,6 @@ public function preview(HTTPRequest $request)
                 ->setSession(Injector::inst()->create(Session::class, []))
                 ->getSession();
         }
-        /** @var ShareToken $shareToken */
         $shareToken = ShareToken::get()->filter('Token', $token)->first();
 
         if (!$shareToken) {

diff --git a/src/Extensions/ShareDraftContentControllerExtension.php b/src/Extensions/ShareDraftContentControllerExtension.php
@@ -2,9 +2,13 @@
 
 namespace SilverStripe\ShareDraftContent\Extensions;
 
+use SilverStripe\Control\Controller;
 use SilverStripe\Core\Extension;
 use SilverStripe\Security\Security;
 
+/**
+ * @extends Extension<Controller>
+ */
 class ShareDraftContentControllerExtension extends Extension
 {
     /**

diff --git a/src/Extensions/ShareDraftContentFileShortcodeProviderExtension.php b/src/Extensions/ShareDraftContentFileShortcodeProviderExtension.php
@@ -8,6 +8,9 @@
 use SilverStripe\Core\Extension;
 use SilverStripe\ShareDraftContent\Controllers\ShareDraftController;
 
+/**
+ * @extends Extension<FileShortcodeProvider>
+ */
 class ShareDraftContentFileShortcodeProviderExtension extends Extension
 {
     /**

diff --git a/src/Extensions/ShareDraftContentRequirementsExtension.php b/src/Extensions/ShareDraftContentRequirementsExtension.php
@@ -2,9 +2,13 @@
 
 namespace SilverStripe\ShareDraftContent\Extensions;
 
+use SilverStripe\CMS\Controllers\CMSMain;
 use SilverStripe\ORM\DataExtension;
 use SilverStripe\View\Requirements;
 
+/**
+ * @extends DataExtension<CMSMain>
+ */
 class ShareDraftContentRequirementsExtension extends DataExtension
 {
     public function init()

diff --git a/src/Extensions/ShareDraftContentSiteTreeExtension.php b/src/Extensions/ShareDraftContentSiteTreeExtension.php
@@ -13,9 +13,10 @@
 use SilverStripe\Subsites\Model\Subsite;
 
 /**
- * @property SiteTree|ShareDraftContentSiteTreeExtension $owner
  * @property string $ShareTokenSalt
  * @method HasManyList<ShareToken> ShareTokens()
+ *
+ * @extends DataExtension<SiteTree&static>
  */
 class ShareDraftContentSiteTreeExtension extends DataExtension
 {