Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove unnecessary @var comments #172

Merged
merged 1 commit into from
Jan 23, 2024
Merged

MNT Remove unnecessary @var comments #172

merged 1 commit into from
Jan 23, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Jan 12, 2024
Closed
emteknetnz
emteknetnz requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR isn't adding any generics, so should have an MNT prefix and a different name

@GuySartorelli GuySartorelli changed the title ENH Add generic types MNT Remove unnecessary @var comments Jan 23, 2024
@GuySartorelli
Copy link
Member Author

Done

@emteknetnz emteknetnz merged commit 16a20fc into silverstripe:5 Jan 23, 2024
9 checks passed
@emteknetnz emteknetnz deleted the pulls/5/add-generics branch January 23, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz