Add multi link support #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import PropTypes from 'prop-types'; | ||
| import classnames from 'classnames'; | ||
|
|
||
| const LinkBox = ({ className, children }) => ( |
There was a problem hiding this comment.
Add some comment to describe what this does.
1 task
|
Hey, is there a timeline to get this merged? I am using linkfield in a project which has a few of these and the experience is pretty clunky, I am a little worried the client might request we go back to linkable because of it. |
maxime-rainville
force-pushed
the
pull/master/multilink
branch
2 times, most recently
from
1e524dd
to
dd4cf68
Compare
|
I've got innovation week in a fortnight. I'll aim to get this across the line then. FYI I've rebased the thing to work with CMS5 |
This was referenced Sep 26, 2023
GuySartorelli
force-pushed
the
pull/master/multilink
branch
from
b2749eb
to
f984376
Compare
|
Rebased and resolved merge conflict as part of additional work that's happening separately. |
Closed
|
Closing in favor of #120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs add support for multi link field via an HasMany relation to Links.
It also adds some extra features like:
Parent issue