FIX Don't split ID into separate digits #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Tested locally, things seem to work correctly, at least in terms of fixing this bug which I was able to replicate.
Note that after inline publishing the block doesn't update its versioned badge to show published, though given that's a separate issue we can merge this as is
|
The versioned badge issue was raised as a regression for 5.2.0: #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is only seen when you have multi-digit IDs. For some reason the ID was coming through as a string, so it didn't get transformed into an array, so we ended up iterating over the string and therefore requesting info for each digit.
Issue