Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Block older version module from using this minor #379

Conversation

maxime-rainville
Copy link
Contributor

Version 3.5 of GraphQL expects different cases for some queries. Older version of modules that depend on this module will not work with 3.5.

This PR aims to make this conflict explicit.

Parent issue

@maxime-rainville
Copy link
Contributor Author

I created fake releases on the creative commoners repo to test this:

  • 3.4.0 tracks the head of the 3.4 branch
  • 3.5.0 includes this fix.

I use this composer file to test.

{
    "name": "maxime/boom",
    "type": "project",
    "authors": [
        {
            "name": "Maxime Rainville",
            "email": "maxime@silverstripe.com"
        }
    ],
    "minimum-stability": "dev",
    "require": {
      "silverstripe/graphql": "^3.4",
      "silverstripe/admin": "~1.7.0"
    },
    "prefer-stable": true,
    "repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:creative-commoners/silverstripe-graphql.git"
        }
    ]
}

I've confirmed that changing the admin constraint between ~1.8.0 and ~1.7.0 will upgrade/downgrade graphql.

@maxime-rainville
Copy link
Contributor Author

I'll double check that the modules included the conflict require graphql 3.5.0 or greater.

@@ -8,6 +8,12 @@
"silverstripe/vendor-plugin": "^1.0",
"webonyx/graphql-php": "~0.12.6"
},
"conflict": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the list of dependent module from packagist to determine what should show in here https://packagist.org/packages/silverstripe/graphql/dependents

I only included supported module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that list looks wrong. admin and versioned shouldn't be here. versioned-admin should.

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis failures are unrelated

@maxime-rainville maxime-rainville merged commit f8ac3f7 into silverstripe:3.5 May 10, 2021
@maxime-rainville maxime-rainville deleted the pulls/3.5/conflict-composer branch May 10, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants