Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queryTransformer back into apollo-client #18

Closed
chillu opened this issue Nov 24, 2016 · 1 comment
Closed

Add queryTransformer back into apollo-client #18

chillu opened this issue Nov 24, 2016 · 1 comment
Assignees

Comments

@chillu
Copy link
Member

chillu commented Nov 24, 2016

This is a subtask of silverstripe/silverstripe-framework#6333

This is a task required to validate and implement the fragment registry approach.

The queryTransformer feature has been removed from apollo-client v0.5 (original code). I'm clarifying why that's the case, and hoping to get it back. We'd also need to change it to pass along the Document rather than OperationDefinition in applyTransformers, otherwise we can't determine the name of the operation.

Ideally we get feedback from the Apollo maintainers if they're open to reinstating the feature (or suggest an alternative). If that doesn't happen, we could push harder by opening a pull request adding back the feature.

@chillu chillu added this to the CMS 4.0.0-alpha4 milestone Nov 24, 2016
@sminnee sminnee changed the title Add queryTransformer back into apollo-client Subtask: Add queryTransformer back into apollo-client Nov 25, 2016
@chillu chillu changed the title Subtask: Add queryTransformer back into apollo-client Add queryTransformer back into apollo-client Dec 5, 2016
@chillu
Copy link
Member Author

chillu commented Dec 10, 2016

The Apollo authors don't see this as a library feature - which is fair enough, we should really solve this outside of the library itself (on the HOC construction). Closing, and adding more notes on the parent ticket.

@chillu chillu closed this as completed Dec 10, 2016
unclecheese pushed a commit to unclecheese/silverstripe-graphql that referenced this issue Jan 27, 2021
…e-assetadmin-i18n

Remove asset-admin specific localisations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant