Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Fix NavigateCommandTest and don't try to write null #11412

Merged
merged 1 commit into from
Oct 1, 2024
Merged

FIX Fix NavigateCommandTest and don't try to write null #11412

merged 1 commit into from
Oct 1, 2024

Conversation

GuySartorelli
Copy link
Member

Fixes https://github.com/silverstripe/silverstripe-framework/actions/runs/11113727805/job/30878716554

1) SilverStripe\Cli\Tests\Command\NavigateCommandTest::testExecute with data set #3 ('test-controller/errorResponse', [], 1, '')
SilverStripe\ORM\Connect\DatabaseException: Couldn't run query:
...
Table 'SS_mysite.SiteTree_Live' doesn't exist

Issue

@GuySartorelli GuySartorelli mentioned this pull request Sep 30, 2024
Open
@GuySartorelli GuySartorelli changed the title MNT Fix NavigateCommandTest FIX Fix NavigateCommandTest and don't try to write null Sep 30, 2024
@emteknetnz emteknetnz merged commit aa2b8c3 into silverstripe:6 Oct 1, 2024
10 checks passed
@emteknetnz emteknetnz deleted the pulls/6/fix-test branch October 1, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz