Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Update @methods on class docblocks #11093

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Dec 13, 2023

Issue silverstripe/.github#163

Used short names instead of fqcn for relation types if class was imported

src/Security/Member.php Outdated Show resolved Hide resolved
src/ORM/Hierarchy/Hierarchy.php Outdated Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to check for belongs_to

@emteknetnz
Copy link
Member Author

Have updated code writer

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit ad8cf99 into silverstripe:5.1 Dec 14, 2023
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.1/docblock branch December 14, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants