Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Use PHPUnit 11 #3000

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/6/phpunit11 branch 3 times, most recently from cbbec51 to d23c78c Compare September 10, 2024 06:01
@@ -5,7 +5,7 @@
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Dev\TestOnly;

class SiteTreeTest_NamespaceMapTest extends SiteTree implements TestOnly
class SiteTreeTest_NamespaceMapTestNode extends SiteTree implements TestOnly
Copy link
Member Author

@emteknetnz emteknetnz Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this file ends in "Test" - phpunit though it was a test class and complained that it had no test cases. So I simply renamed it to match its $table_name

@@ -5,7 +5,7 @@
use SilverStripe\CMS\Controllers\ContentController;
use SilverStripe\Dev\TestOnly;

class SiteTreeTest_NamespaceMapTestController extends ContentController implements TestOnly
class SiteTreeTest_NamespaceMapTestNodeController extends ContentController implements TestOnly
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was renamed to match the corresponding SiteTreeTest_NamespaceMapTestNode which was also renamed

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once all other PRs are approved

@GuySartorelli GuySartorelli merged commit b30cb3e into silverstripe:6 Sep 18, 2024
4 of 14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/phpunit11 branch September 18, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants