MNT Tweak behat test to look for tag with specific attribute itstead of looking for a specifc string in the HTML #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Jun 20, 2024
…of looking for a specifc string in the HTML
maxime-rainville
force-pushed
the
pulls/5/image-rendering-unity
branch
from
b197374
to
747de27
Compare
|
Fixed my booboo. |
emteknetnz
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing because it was looking for a very specific string in the HTML. Just checking for a tag with a specific attribute is more reliable because it doesn't depend on the order of parameter.
Parent issue