Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX IE 11 rendering issues in Page Editor UI #2468

Merged

Conversation

Cheddam
Copy link
Member

@Cheddam Cheddam commented Aug 15, 2019

This PR, alongside silverstripe/silverstripe-admin#931, aims to drastically improve the usability of the Page Editor UI in Internet Explorer 11, particularly at mid-sized resolutions. In particular, the changes here:

  • Set a specific base width on the two main elements holding the editor and preview pane, so that Internet Explorer doesn't collapse them.
  • Removes the fill-width class from the editor header, which was causing its tabs to collapse onto and overlap the second-level tabs.

There is still an outstanding IE issue where the Page Editor UI stops adapting to smaller viewports at around 850px, but with this PR users will have a far more usable experience. I'm also seeing some sizing issues when the Elemental Editor is present, but the UI is usable and fixes itself when the viewing mode is changed.

Resolves #2432.
Resolves #2245.

@brynwhyman
Copy link

Wondering if this might help resolve this issue too: #2345

Internet Explorer needs a little extra help with its math to avoid the
entire UI collapsing in on itself.
@Cheddam Cheddam force-pushed the pulls/4/ie-editor-layout-issues branch from 4bf18be to 65f4ec5 Compare August 15, 2019 21:45
@Cheddam Cheddam changed the base branch from 4 to 4.4 August 15, 2019 21:48
@NightJar NightJar self-assigned this Aug 15, 2019
@robbieaverill
Copy link
Contributor

Who do we appreciate

@NightJar
Copy link
Contributor

Tested (with companion PR silverstripe/silverstripe-admin#931), can recreate neither #2432 nor #2245 anymore, well done @Cheddam you hero ❤️ 🎉

Copy link
Contributor

@NightJar NightJar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and with minimal changes, that was unexpected!

@NightJar NightJar merged commit 8606f94 into silverstripe:4.4 Aug 16, 2019
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the CMS content editing in IE11, nice. I've found it breaks the split screen view of page history though (taken on MacOS Chrome, and shows up in IE11 when you load the history page directly rather than with PJAX)

image

The history screen is still pretty broken in IE11 when you load it with PJAX:

image

Also when you load the history tab with PJAX there's this weird loop issue where you can click on the split mode toggle and send it into a crazy loop: https://screencast-o-matic.com/watch/cqjDcVtn73

@NightJar NightJar deleted the pulls/4/ie-editor-layout-issues branch August 16, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants