Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Dependencies for CMS 6 #743

Conversation

emteknetnz
Copy link
Member

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to bump or ditch silverstripe/widgets, silverstripe/comments, and silverstripe/content-widget (I'm in favour of ditching them since they're not supported)

@emteknetnz emteknetnz force-pushed the pulls/5/module-standardiser-1708320403 branch from a7c3d29 to 9a99901 Compare February 20, 2024 02:34
@emteknetnz
Copy link
Member Author

emteknetnz commented Feb 20, 2024

They're not supported in CMS 5 so won't get new branches for CMS 6. Have removed.

Have created follow on card to remove code #744 - everything is behing class_exists() conditionals so no harm in keeping the dead code for now

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failures are expected at this stage so ignoring CI.

@GuySartorelli GuySartorelli merged commit 84102eb into silverstripe:5 Feb 20, 2024
5 of 12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/module-standardiser-1708320403 branch February 20, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants