Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Use class from new template engine module #289

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Nov 3, 2024

The template engine code is in its own module now, so we need to add it as a dependency and update the use statement. Going with API since that feels like it takes precedence over DEP and updating a use statement feels like a API commit to me, but I'm happy to change the prefix if the reviewer wants me to.

CI for this can't go green until silverstripe/silverstripe-framework#11451 has been merged

Issue

@emteknetnz emteknetnz merged commit 97f5092 into silverstripe:6 Nov 6, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants