Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Refactor FileIDHelper classes to reduce code duplication #587

Merged

Conversation

GuySartorelli
Copy link
Member

This is the refactoring from #585, split out as requested in #585 (review)

Issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@emteknetnz emteknetnz merged commit 3326749 into silverstripe:2 Jan 25, 2024
9 checks passed
@emteknetnz emteknetnz deleted the pulls/2/refactoring-for-585 branch January 25, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants