Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Add generic types #1433

Merged
merged 1 commit into from
Jan 18, 2024
Merged

ENH Add generic types #1433

merged 1 commit into from
Jan 18, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Jan 10, 2024
Closed
emteknetnz
emteknetnz approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on green - there's a failing behat test which I've tried re-running - if it's still failing it's probably fine, the other behat test on a different php version is green

@emteknetnz emteknetnz merged commit badbc4f into silverstripe:2 Jan 18, 2024
11 of 12 checks passed
@emteknetnz emteknetnz deleted the pulls/2/add-generics branch January 18, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz