DEP Remove unsupported modules #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/2/remove
branch
from
833c365
to
1339ff6
Compare
maxime-rainville
requested changes
Jun 8, 2023
composer.json
Outdated
| @@ -9,10 +9,7 @@ | |||
| "silverstripe/recipe-cms": "5.x-dev", | |||
| "silverstripe/blog": "4.x-dev", | |||
| "silverstripe/widgets": "3.x-dev", | |||
There was a problem hiding this comment.
Suggested change
| "silverstripe/widgets": "3.x-dev", |
There was a problem hiding this comment.
Looks like we did make a mistake including this in 2.0.0
I've created a changelog PR to mention this - silverstripe/developer-docs#283
| @@ -9,10 +9,7 @@ | |||
| "silverstripe/recipe-cms": "5.x-dev", | |||
| "silverstripe/blog": "4.x-dev", | |||
| "silverstripe/widgets": "3.x-dev", | |||
| "silverstripe/content-widget": "3.x-dev", | |||
| "silverstripe/spamprotection": "4.x-dev", | |||
There was a problem hiding this comment.
Is there any point having spam protection in here if comments are not there.
There was a problem hiding this comment.
Probably not, though spam protection is still supported so it should stay there
phpunit.xml.dist
Outdated
| @@ -5,10 +5,7 @@ | |||
| <directory>vendor/silverstripe/blog/tests</directory> | |||
| <directory>vendor/silverstripe/lumberjack/tests</directory> | |||
| <directory>vendor/silverstripe/widgets/tests</directory> | |||
There was a problem hiding this comment.
Suggested change
| <directory>vendor/silverstripe/widgets/tests</directory> |
emteknetnz
force-pushed
the
pulls/2/remove
branch
from
1339ff6
to
04ff922
Compare
emteknetnz
force-pushed
the
pulls/2/remove
branch
from
04ff922
to
b2ae936
Compare
maxime-rainville
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/recipe-kitchen-sink#29