Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add is_ci config value #25

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Apr 10, 2024

Issue silverstripe/silverstripe-admin#1671

Do not merge until silverstripe/silverstripe-behat-extension#268 has been merged and released AND the version for 4.13 has also been merged and released - otherwise CI will break

Do not merge until silverstripe/gha-ci#117 has been merged and released AND the version for 4.13 has also been merged and released - otherwise CI will break

@emteknetnz emteknetnz marked this pull request as draft April 10, 2024 23:15
@emteknetnz emteknetnz marked this pull request as ready for review April 10, 2024 23:43
@emteknetnz emteknetnz marked this pull request as draft April 11, 2024 00:04
@emteknetnz emteknetnz marked this pull request as ready for review April 11, 2024 00:37
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Will wait to merge until the prerequisite changes are made upstream.

@GuySartorelli GuySartorelli merged commit 2dc432f into silverstripe:1.1 Apr 15, 2024
4 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1.1/behat branch April 15, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants