NEW Migrate documentation linting to a new repository #1
Conversation
GuySartorelli
force-pushed
the
pulls/1/migrate-to-repo
branch
from
984984e
to
827234d
Compare
phpcs.xml
Outdated
There was a problem hiding this comment.
This file is unaltered from the developer docs repo
There was a problem hiding this comment.
Ugh I really hate GitHub saying these are outdated. They're not! Show them in the files tab! Grr.
I wish we could manually mark comments as "not outdated"
[end rant]
package.json
Outdated
There was a problem hiding this comment.
The dependencies in this file are unaltered from the developer docs repo
composer.json
Outdated
There was a problem hiding this comment.
The dependencies in this file are unaltered from the developer docs repo
.markdownlint.yml
Outdated
There was a problem hiding this comment.
This file is unaltered from the developer docs repo
.markdownlint-cli2.mjs
Outdated
There was a problem hiding this comment.
This file is unaltered from the developer docs repo except for some minor styling tweaks and adding ignores
.eslintrc.js
Outdated
There was a problem hiding this comment.
This file is unaltered from the developer docs repo except for the addition of rules.ignorePatterns
GuySartorelli
force-pushed
the
pulls/1/migrate-to-repo
branch
7 times, most recently
from
0bfcdbc
to
f5fcb38
Compare
GuySartorelli
force-pushed
the
pulls/1/migrate-to-repo
branch
from
f5fcb38
to
8e3b301
Compare
bin/ss-docs-lint
Outdated
| cp "${DOCS_LINT_DIR}/package.json" package.json | ||
| yarn install |
There was a problem hiding this comment.
I tried to avoid this, I really did, but the js linters just refused to lint anything that wasn't a child directory of the one with the package.json file.
GuySartorelli
force-pushed
the
pulls/1/migrate-to-repo
branch
from
8e3b301
to
6a4fe85
Compare
GuySartorelli
force-pushed
the
pulls/1/migrate-to-repo
branch
from
6a4fe85
to
0526531
Compare
bin/ss-docs-lint
Outdated
| # otherwise the linting tools will refuse to lint for us. | ||
| if [[ $WITH_MD == 1 || $WITH_JS == 1 ]]; then | ||
| cp "${DOCS_LINT_DIR}/package.json" package.json | ||
| yarn install --network-concurrency 1 |
There was a problem hiding this comment.
--network-concurrency 1 mirrors what's done for the js CI run - this is 90% of the time gonna be run in CI so lets reduce the chance of it throwing errors in our face.
bin/ss-docs-lint
Outdated
| @@ -0,0 +1,197 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Done, though I don't like it.
GuySartorelli
force-pushed
the
pulls/1/migrate-to-repo
branch
from
0526531
to
ef08613
Compare
GuySartorelli
force-pushed
the
pulls/1/migrate-to-repo
branch
from
ef08613
to
05093af
Compare
Issue