Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Updates for symfony/mailer #92

Merged
merged 1 commit into from
Oct 19, 2022
Merged

DOC Updates for symfony/mailer #92

merged 1 commit into from
Oct 19, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as draft September 28, 2022 22:24
@emteknetnz emteknetnz mentioned this pull request Sep 28, 2022
Closed
1 task
@emteknetnz emteknetnz force-pushed the pulls/5/symfony-mailer branch 4 times, most recently from 94c6ccf to 3e3adad Compare September 29, 2022 04:01
@emteknetnz emteknetnz marked this pull request as ready for review September 29, 2022 04:26
GuySartorelli
GuySartorelli requested changes Sep 29, 2022
View reviewed changes
en/02_Developer_Guides/10_Email/index.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/10_Email/index.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/10_Email/index.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/10_Email/index.md Show resolved Hide resolved
en/02_Developer_Guides/10_Email/index.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/symfony-mailer branch 2 times, most recently from 28d5737 to 0eae565 Compare September 29, 2022 22:47
@GuySartorelli GuySartorelli mentioned this pull request Oct 2, 2022
Merged
GuySartorelli
GuySartorelli requested changes Oct 2, 2022
View reviewed changes
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/10_Email/index.md Show resolved Hide resolved
en/02_Developer_Guides/10_Email/index.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Show resolved Hide resolved
GuySartorelli
GuySartorelli requested changes Oct 4, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mention the strict typing changes (whether explicitly or just as a "we have also added strict types to many parameters and return types in this class" I'm not fussed) so people don't get caught out by it and then complain it wasn't in the changelogs.

Changes to parameter names are also API changes and need to be mentioned here.

en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/symfony-mailer branch 7 times, most recently from 3ea400f to 25c39ff Compare October 6, 2022 00:30
GuySartorelli
GuySartorelli requested changes Oct 6, 2022
View reviewed changes
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Show resolved Hide resolved
GuySartorelli
GuySartorelli requested changes Oct 18, 2022
View reviewed changes
en/04_Changelogs/5.0.0.md Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Show resolved Hide resolved
en/04_Changelogs/5.0.0.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/symfony-mailer branch 3 times, most recently from 7758801 to 34bb612 Compare October 18, 2022 22:52
@emteknetnz
Copy link
Member Author

@GuySartorelli

We should also mention the strict typing changes (whether explicitly or just as a "we have also added strict types to many parameters and return types in this class" I'm not fussed) so people don't get caught out by it and then complain it wasn't in the changelogs.
Changes to parameter names are also API changes and need to be mentioned here.

I've added a sentence for these two things

GuySartorelli
GuySartorelli approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll hold off merging until the framework PR is ready to merge just in case.

@GuySartorelli GuySartorelli merged commit 098edc8 into silverstripe:5 Oct 19, 2022
@GuySartorelli GuySartorelli deleted the pulls/5/symfony-mailer branch October 19, 2022 02:52
@GuySartorelli GuySartorelli mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli