Review of the Silverstripe CMS 5.2.0 changelog #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Mar 19, 2024
Comment on lines
-421
to
427
| if (DB::get_conn()->supportsCteQueries()) { | ||
| // Supports non-recursive CTE clause | ||
| } elseif (DB::get_conn()->supportsCteQueries(true)) { | ||
| if (DB::get_conn()->supportsCteQueries(true)) { | ||
| // Supports recursive CTE clause | ||
| } elseif (DB::get_conn()->supportsCteQueries()) { | ||
| // Supports non-recursive CTE clause | ||
| } else { | ||
| // No CTE support | ||
| } |
There was a problem hiding this comment.
Unrelated change - with the old code, the elseif condition would never have been executed because if it doesn't support non-recursive queries it definitely doesn't support recursive ones.
GuySartorelli
commented
Mar 19, 2024
There was a problem hiding this comment.
Changes here reflect the changes in the changelog for the same content
GuySartorelli
commented
Mar 19, 2024
There was a problem hiding this comment.
Unrelated changes - just noticed a couple of cases where this list about the writing style doesn't follow its own rules.
GuySartorelli
commented
Mar 19, 2024
| - Use gender neutral language throughout the document, unless referencing a specific person. Use them, they, their, instead of he and she, his or her. | ||
| - Use simple language and words. Avoid uncommon jargon and overly long words. Remember that not everyone speaks English as their primary language. | ||
| - Use UK English, not US English. Silverstripe CMS is proudly a New Zealand open source project we use the UK spelling and forms of English. The most common of these differences are -ize vs -ise, or -or vs our (eg color vs colour). | ||
| - Write in an active and direct voice. | ||
| - Avoid saying words like "obviously" or "of course". Things that are obvious to you as the writer may not be so obvious to the person reading the documentation. | ||
| - Keep documentation lines shorter than 120 characters. |
There was a problem hiding this comment.
We decided to explicitly not enforce this, so we shouldn't say it's a rule
GuySartorelli
commented
Mar 19, 2024
There was a problem hiding this comment.
Should be a little less blurry since it's larger, and shows both of the versioned labels
GuySartorelli
commented
Mar 19, 2024
Comment on lines
-32
to
+34
| This release includes several security fixes. Review the individual vulnerability disclosure for more detailed descriptions of each security fix. We highly encourage upgrading your project to include the latest security patches. | ||
| Some security fixes that were previously released in the January security release that are mentioned in the [Silverstripe CMS security patches January 2024](https://www.silverstripe.org/blog/silverstripe-cms-security-patches-january-2024/) blog post are listed below. | ||
|
|
||
| Review the individual vulnerability disclosure for more detailed descriptions of each security fix. We highly encourage upgrading your project to include the latest security patches. |
There was a problem hiding this comment.
Copied over from the beta changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review of the Silverstripe CMS 5.2.0 changelog.
Commits
New items added to the changelog
I found these in the commits list from the beta changelog. If you disagree with any of these being in the changelog let me know, there's only a couple here that I'm really adamant on and the rest I could take or leave.
extra_requirements_i18nconfig toLeftAndMainsilverstripe-admin#1678Issues
Pull request checklist