Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Update supported PHP version for CMS 5.2 #403

Merged
merged 1 commit into from
Dec 13, 2023
Merged

DOC Update supported PHP version for CMS 5.2 #403

merged 1 commit into from
Dec 13, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Nov 22, 2023
Closed
4 tasks
@sabina-talipova sabina-talipova marked this pull request as draft November 22, 2023 20:31
GuySartorelli
GuySartorelli reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The branch this PR is targetting now has a CI action. This PR will need to be force-pushed to run the CI, and the CI must be green before merging.

@sabina-talipova sabina-talipova force-pushed the pulls/5/update-supported-php-version branch from 4b1a401 to e2c2ff1 Compare December 12, 2023 21:00
@sabina-talipova sabina-talipova marked this pull request as ready for review December 12, 2023 21:01
GuySartorelli
GuySartorelli approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will hold off merging until the CI PR is merged

@GuySartorelli GuySartorelli merged commit 034594c into silverstripe:5 Dec 13, 2023
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/update-supported-php-version branch December 13, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli