Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update bug reports page #357

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Oct 4, 2023

Comment on lines -21 to -23
* Which modules does this issue belong to? Each one has its own issue tracker.
If you are unsure, [create an issue](https://github.com/silverstripe/silverstripe-framework/issues/new) on the the "framework" repository.
* Note that [documentation issues](https://github.com/silverstripe/developer-docs/issues) are tracked in the "developer-docs" repository.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which module the issue belongs to moved to the next section

Comment on lines -25 to -28
* The bugtracker is not the place to discuss enhancements, please use
the ["feature ideas" forum category](https://forum.silverstripe.org/c/feature-ideas) and our [community channels](https://www.silverstripe.org/community).
Only log enhancement tickets if they gather a large interest in the community
and the enhancement is likely to be implemented in the next couple of months.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to put this here, there's a whole section for this further down.

Comment on lines +11 to +13
[alert]
If you think you've found a security issue, please use [the specific process](#reporting-security-issues) for those. Do _not_ raise a security issue in GitHub.
[/alert]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this really prominent to reduce the risk of public security issues

Comment on lines +62 to +68
[warning]
If you think a bug may have security implications, do not create a GitHub issue for it. This may lead to a zero-day vulnerability.
[/warning]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this more prominent in case anyone missed it the first time

Comment on lines -71 to -74
## Sharing your Opinion

* [forum.silverstripe.org](http://forum.silverstripe.org): Forums on silverstripe.org
* [All issues across modules](https://www.silverstripe.org/community/contributing-to-silverstripe/github-all-core-issues)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section has no information in it... I don't know what the purpose of it was so I removed it outright.

Comment on lines -76 to -86
## Identifying issues and pull request relevant to your own project {#identifying-issues}

Our [issue browser](https://silverstripe-github-issues.now.sh/) can be helpful to identify known issues and pending pull requests in
[supported modules](https://www.silverstripe.org/software/addons/silverstripe-commercially-supported-module-list/).
But you're usually only running some of these modules, and others
from the [wider module ecosystem](https://addons.silverstripe.org).

In order to only show issues and pull requests relevant to your project,
we've written a little [composer utility](https://github.com/silverstripe/silverstripe-github-issue-search-composer-util)
which inspects your own `composer.lock` file dependencies,
and searches across all Silverstripe CMS modules in there.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a "how to find bugs that might affect my project" page, and the tool noted here isn't maintained.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URLs here for the issue tracker are probably not the best URLs to use. There's a discussion on this in the CMS Squad slack channel, and in the meantime I'll just leave them as is.

@GuySartorelli GuySartorelli force-pushed the pulls/4.13/contributing-docs1 branch 2 times, most recently from 89c9169 to 9b979f9 Compare October 4, 2023 21:55
problem can collaborate with you to develop a fix.
* If you are unsure, [create an issue](https://github.com/silverstripe/silverstripe-framework/issues/new) on the the "framework" repository.
* Note that [documentation issues](https://github.com/silverstripe/developer-docs/issues) are tracked in the "developer-docs" repository.
* Describe the steps required to reproduce your issue, and the expected outcome. Example code, screenshots, and screencasts can help here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Describe the steps required to reproduce your issue, and the expected outcome. Example code, screenshots, and screencasts can help here.
* Describe the steps required to reproduce your issue, and the expected outcome. Example code, screenshots, and videos can help here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@emteknetnz emteknetnz merged commit 01c3692 into silverstripe:4.13 Oct 12, 2023
@emteknetnz emteknetnz deleted the pulls/4.13/contributing-docs1 branch October 12, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants