Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Staticpublishqueue changelog entry #331

Merged
merged 1 commit into from
Aug 30, 2023
Merged

DOC Staticpublishqueue changelog entry #331

merged 1 commit into from
Aug 30, 2023

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 22, 2023 •
edited
Loading

@emteknetnz
Copy link
Member Author

@chrispenny could I get you to check you're happy with this

chrispenny
chrispenny reviewed Aug 22, 2023
View reviewed changes
Copy link

@chrispenny chrispenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If you'd like to include the possible options in this changelog, then I've added a suggestion. I think you've linked to the full docs though, which is also fine.

en/04_Changelogs/5.1.0.md Show resolved Hide resolved
@emteknetnz emteknetnz mentioned this pull request Aug 30, 2023
Closed
GuySartorelli
GuySartorelli approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@GuySartorelli GuySartorelli merged commit 739caea into silverstripe:5 Aug 30, 2023
@GuySartorelli GuySartorelli deleted the pulls/5/static branch August 30, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispenny chrispenny chrispenny left review comments

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @chrispenny @GuySartorelli