Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add minor release policy #308

Conversation

maxime-rainville
Copy link
Contributor

@maxime-rainville maxime-rainville commented Jul 24, 2023

Just documenting the actual process we follow for minor release.

There's nothing really new here aside from the predefined minor release months.

Parent issue

@maxime-rainville maxime-rainville force-pushed the pulls/5.0/minor-release-policy branch 3 times, most recently from 46743be to 6b498a1 Compare July 25, 2023 00:22
@maxime-rainville maxime-rainville marked this pull request as ready for review July 25, 2023 00:40
@maxime-rainville
Copy link
Contributor Author

@silverstripe/core-team ^ Maybe have a read and let us know if you have feedback or concern with this action plan.

@emteknetnz
Copy link
Member

emteknetnz commented Jul 25, 2023

@maxime-rainville Parent issue is on a private repo so people outside of Silverstripe Ltd won't be able to view it

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to target 5.0 and not 4.13 for this change?

en/06_Project_Governance/07_Supported_Modules.md Outdated Show resolved Hide resolved
en/06_Project_Governance/08_Fixed_dependencies.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
en/06_Project_Governance/06_Minor_release_policy.md Outdated Show resolved Hide resolved
@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 2, 2023

Not answered yet @maxime-rainville: #308 (review)
Also see all unresolved conversations.

@GuySartorelli
Copy link
Member

@maxime-rainville you still haven't addressed #308 (review)

For convenience:

Is there a reason to target 5.0 and not 4.13 for this change?

@maxime-rainville
Copy link
Contributor Author

Is there a reason to target 5.0 and not 4.13 for this change?

In a perfect world, process that don't relate to a specific major would be documented in something in-temporal. Until such time, I think it makes sense to say that the latest major branch is tho source of truth.

@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 2, 2023

In a perfect world, process that don't relate to a specific major would be documented in something in-temporal. Until such time, I think it makes sense to say that the latest major branch is tho source of truth.

I disagree with that approach. I think any supported documentation should be accurate. Imagine the case where someone is looking at CMS 4 documentation for their CMS 4 project, and comes across something that they think needs to be changed. They're not going to then swap over to the CMS 5 docs to see the contribution guide/etc. They're gonna click on it where it is.

Obviously this doc is a little less important that it be shared across both versions in the same way, because we won't be releasing new minors for CMS 4 - but the principal of the matter and the precedent we set is important here.
I think until we move governance docs somewhere they won't be version gated, which isn't likely to happen until the dot org rebuild is complete, we should make sure our governance doc is always up-to-date for 4.13 and 5.x

It probably does belong in CMS 4 docs regardless though, as it does also speak about security patch windows, which is relevant to CMS 4 users.

@GuySartorelli
Copy link
Member

Now that I've put my reasoning there, if you still feel strongly about this being merged only into 5.0, say so and it'll be done.

author Maxime Rainville <maxime@silverstripe.com> 1690197365 +1200
committer Maxime Rainville <maxime@silverstripe.com> 1690875014 +1200

DOC Add minor release policy
@maxime-rainville maxime-rainville changed the base branch from 5.0 to 4.13 August 3, 2023 06:06
@maxime-rainville
Copy link
Contributor Author

I don't care strongly either. I've reset the branch to target 4.13 and cherry pick the commit there.

FYI We'll have to renumber the "fix dependency" page on merge up.

@GuySartorelli GuySartorelli merged commit bdc5202 into silverstripe:4.13 Aug 3, 2023
@GuySartorelli GuySartorelli deleted the pulls/5.0/minor-release-policy branch August 3, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants