-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Add minor release policy #308
DOC Add minor release policy #308
Conversation
46743be
to
6b498a1
Compare
@silverstripe/core-team ^ Maybe have a read and let us know if you have feedback or concern with this action plan. |
6b498a1
to
ae63e52
Compare
@maxime-rainville Parent issue is on a private repo so people outside of Silverstripe Ltd won't be able to view it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to target 5.0 and not 4.13 for this change?
dd1e43c
to
fafc74b
Compare
Not answered yet @maxime-rainville: #308 (review) |
@maxime-rainville you still haven't addressed #308 (review) For convenience:
|
20f67a0
to
dc57e8d
Compare
In a perfect world, process that don't relate to a specific major would be documented in something in-temporal. Until such time, I think it makes sense to say that the latest major branch is tho source of truth. |
I disagree with that approach. I think any supported documentation should be accurate. Imagine the case where someone is looking at CMS 4 documentation for their CMS 4 project, and comes across something that they think needs to be changed. They're not going to then swap over to the CMS 5 docs to see the contribution guide/etc. They're gonna click on it where it is. Obviously this doc is a little less important that it be shared across both versions in the same way, because we won't be releasing new minors for CMS 4 - but the principal of the matter and the precedent we set is important here. It probably does belong in CMS 4 docs regardless though, as it does also speak about security patch windows, which is relevant to CMS 4 users. |
Now that I've put my reasoning there, if you still feel strongly about this being merged only into 5.0, say so and it'll be done. |
dc57e8d
to
51ad53f
Compare
I don't care strongly either. I've reset the branch to target 4.13 and cherry pick the commit there. FYI We'll have to renumber the "fix dependency" page on merge up. |
Just documenting the actual process we follow for minor release.
There's nothing really new here aside from the predefined minor release months.
Parent issue