Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Eager loading #277

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/5/eager-load branch 2 times, most recently from 333623a to c99fba0 Compare May 29, 2023 06:30
@emteknetnz emteknetnz marked this pull request as ready for review May 29, 2023 12:48
@emteknetnz emteknetnz force-pushed the pulls/5/eager-load branch 3 times, most recently from 3b7336a to cffa34d Compare May 30, 2023 00:03
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Probably, it needs to provide a little bit more information how to use eagerLoad with some complex relationships.

Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small suggestions how we can improve and make the examples more sense.

en/02_Developer_Guides/00_Model/02_Relations.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/00_Model/02_Relations.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Nice work!

@sabina-talipova sabina-talipova merged commit 4511161 into silverstripe:5 Jun 8, 2023
@sabina-talipova sabina-talipova deleted the pulls/5/eager-load branch June 8, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants