Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Revert pull requests #197, #187, #184 #199

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions en/02_Developer_Guides/00_Model/10_Versioning.md
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ module.exports = [
console.log('Hello world');
```

At this stage, running `yarn build` should correctly build `app/client/dist/js/bundle.js`.
At this stage, running `yarn build` correctly build `app/client/dist/js/bundle.js`.

[notice]
Don't forget to [configure your project's "exposed" folders](/developer_guides/templates/requirements/#configuring-your-project-exposed-folders) and run `composer vendor-expose` on the command line so that the browser has access to your new dist js file.
Expand Down Expand Up @@ -1207,7 +1207,7 @@ mutation revertToMyVersionedObject($id:ID!, $toVersion:Int!) {

const config = {
props: ({ mutate, ownProps: { actions } }) => {
const revertToVersion = (id, toVersion) => mutate({
const revertToMyVersionedObject = (id, toVersion) => mutate({
variables: {
id,
toVersion,
Expand All @@ -1217,7 +1217,7 @@ const config = {
return {
actions: {
...actions,
revertToVersion,
revertToMyVersionedObject,
},
};
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -920,16 +920,15 @@ Finally, let's make a really simple container app which holds a header and our n

```js
import React from 'react';
import { inject } from 'lib/Injector';
import Notes from './components/Notes';

const App = () => (
const App = ({ ListComponent }) => (
<div>
<h3>Notes</h3>
<Notes />
</div>
);

export default App;
```

**my-module/client/src/index.js**
Expand Down Expand Up @@ -1225,7 +1224,7 @@ SilverStripe\GraphQL\Schema\Schema:
```yml
App\Model\Note:
fields:
priority: true
Priority: true
```

##### Graphql 3 {#applying-extensions-gql-v3}
Expand Down Expand Up @@ -1487,8 +1486,8 @@ Lastly, let's just register all this with `Injector`.

```js
//...
import AddForm from '../components/AddForm';
import createNote from '../state/createNote';
import AddForm from './components/AddForm';
import createNote from './state/createNote';

const registerDependencies = () => {
//...
Expand Down Expand Up @@ -1576,7 +1575,7 @@ All we've done here is overridden the `props` setting in the `CreateNote` apollo

Now we just need to register these transforms, and we're done!

**app/client/src/boot.js**
**app/client/src/index.js**

```js
//...
Expand Down