Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update templates section #198

Merged

Conversation

GuySartorelli
Copy link
Member

A (relatively quick) sweep over the templates section of the docs to update any false or outdated information.

Note: This should be reviewed after #188

Scope

The primary purpose of this PR is to ensure that:

  1. code examples actually work in CMS 5
  2. written documentation is factually correct

In many cases I may have also augmented the existing documentation to make it clearer or to add information I felt was missing.

There may also be cases where I have updated code examples or written documentation to better reflect best practices - but that is not the main purpose of this PR. If there are areas where I have not updated examples or docs to reflect best practices (but those examples work and the docs are factually correct) then they are out of scope for this PR.

Formatting that I haven't explicitly touched is definitely out of scope.

Issue

@GuySartorelli GuySartorelli marked this pull request as draft March 27, 2023 03:09
@GuySartorelli GuySartorelli mentioned this pull request Mar 27, 2023
@GuySartorelli GuySartorelli force-pushed the pulls/5.0/templates-section branch 8 times, most recently from 542005e to d2afd1a Compare April 4, 2023 04:04
@GuySartorelli GuySartorelli marked this pull request as ready for review April 5, 2023 00:34
@GuySartorelli GuySartorelli marked this pull request as draft April 5, 2023 03:34
@GuySartorelli GuySartorelli marked this pull request as ready for review April 5, 2023 03:34
@emteknetnz
Copy link
Member

Need to rebase

@GuySartorelli
Copy link
Member Author

Rebased

@emteknetnz emteknetnz merged commit ced9759 into silverstripe:5.0 Apr 17, 2023
@emteknetnz emteknetnz deleted the pulls/5.0/templates-section branch April 17, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants