Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add graphql rebuild section #193

Merged

Conversation

emteknetnz
Copy link
Member

en/04_Changelogs/4.13.0.md Outdated Show resolved Hide resolved
@@ -75,4 +77,16 @@ If you are using this release as a step towards upgrading to Silverstipe CMS 5,

## Features and enhancements

### GraphQL v4 additional fallback {#graphql-v4-additional-fallback}
Copy link
Member

@GuySartorelli GuySartorelli Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### GraphQL v4 additional fallback {#graphql-v4-additional-fallback}
### GraphQL v4 additional fallback

I won't hold back merging for this, but as I've mentioned a few times before you don't need to add the anchor if it's identical to the default anchor. Applies to the one below as well.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, holding off merge until the code changes are merged.

@GuySartorelli
Copy link
Member

Oops forgot to merge this

@GuySartorelli GuySartorelli merged commit 16c67fd into silverstripe:4.13 Mar 28, 2023
@GuySartorelli GuySartorelli deleted the pulls/4.13/graphql branch March 28, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants