Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Fix typo in graphql upgrade notes #162

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Feb 16, 2023

The yaml config for a resolver must be a correct PHP callable, which means the actual method name needs to be used. I suspect at some stage there was going to be some magic to add "resolve" to the beginning of the method name in PHP before executing.... in any case, the upgrade notes were incorrect.

@michalkleiner michalkleiner merged commit 13d79c0 into silverstripe:4.12 Feb 17, 2023
@michalkleiner michalkleiner deleted the pulls/4.12/fix-resolver-is-callable branch February 17, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants