Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add information about deprecations #131

Merged

Conversation

emteknetnz
Copy link
Member

Issue #82

Replacement for #126

@GuySartorelli
Copy link
Member

@emteknetnz The first three changes I requested in the old PR haven't been made - I didn't even bother checking the rest, I assume they haven't been either. I'm guessing you just forgot to push?

@emteknetnz
Copy link
Member Author

Yup forgot to push, have done this now

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just a few changes to make the new deprecations docs less CMS 5 centric, so we don't have to remember to update them every two years.

en/05_Contributing/04_Release_Process.md Outdated Show resolved Hide resolved
en/05_Contributing/04_Release_Process.md Outdated Show resolved Hide resolved
en/05_Contributing/18_Deprecations.md Outdated Show resolved Hide resolved
en/05_Contributing/18_Deprecations.md Outdated Show resolved Hide resolved
en/05_Contributing/18_Deprecations.md Outdated Show resolved Hide resolved
en/05_Contributing/18_Deprecations.md Outdated Show resolved Hide resolved
en/05_Contributing/18_Deprecations.md Outdated Show resolved Hide resolved
en/05_Contributing/18_Deprecations.md Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli merged commit 8fd6641 into silverstripe:4.12 Dec 20, 2022
@GuySartorelli GuySartorelli deleted the pulls/4.12/deprecations branch December 20, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants