Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Word Alignment engine: #506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Word Alignment engine: #506

wants to merge 1 commit into from

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 9, 2024

  • Add HTTP API
  • Add Grpc
  • Add Echo
  • Add Serval services

Need to do:

  • Add machine level implementation
  • Add tests

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 7.45044% with 1354 lines in your changes missing coverage. Please review.

Project coverage is 47.92%. Comparing base (083d68e) to head (bb06c3f).

Files with missing lines Patch % Lines
...ment/Controllers/WordAlignmentEnginesController.cs 0.00% 412 Missing ⚠️
...src/Serval.WordAlignment/Services/EngineService.cs 5.93% 333 Missing ⚠️
...ignment/Services/WordAlignmentPlatformServiceV1.cs 0.00% 293 Missing ⚠️
.../src/Serval.WordAlignment/Services/BuildService.cs 0.00% 38 Missing ⚠️
...ks/Consumers/WordAlignmentBuildFinishedConsumer.cs 0.00% 29 Missing ⚠️
...oks/Consumers/WordAlignmentBuildStartedConsumer.cs 0.00% 26 Missing ⚠️
...lignment/Configuration/IServalBuilderExtensions.cs 35.48% 16 Missing and 4 partials ⚠️
...l.WordAlignment/Contracts/WordAlignmentBuildDto.cs 0.00% 15 Missing ⚠️
...rc/Serval/src/Serval.WordAlignment/Models/Build.cs 0.00% 14 Missing ⚠️
...c/Serval/src/Serval.WordAlignment/Models/Engine.cs 0.00% 14 Missing ⚠️
... and 26 more

❗ There is a different number of reports uploaded between BASE (083d68e) and HEAD (bb06c3f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (083d68e) HEAD (bb06c3f)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   56.97%   47.92%   -9.06%     
==========================================
  Files         277      316      +39     
  Lines       14194    17093    +2899     
  Branches     1907     2379     +472     
==========================================
+ Hits         8087     8191     +104     
- Misses       5519     8310    +2791     
- Partials      588      592       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Add HTTP API
* Add Grpc
* Add Echo (as single engine)
* Add Serval services
* Add webhooks
* Update docker-compose
* Basic echo works

All engines need to have different names, even if they are in different controllers.  Calling Echo for word alignment, echo-word-alignment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants