Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore accidentally removed notebooks #255

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Oct 9, 2024

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.88%. Comparing base (881b719) to head (af7d56d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   69.88%   69.88%           
=======================================
  Files         379      379           
  Lines       31732    31732           
  Branches     4450     4450           
=======================================
  Hits        22175    22175           
  Misses       8525     8525           
  Partials     1032     1032           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

Why are these files here? Why are they duplicated in machine.py? Don't the ipynb files not make any sense without machine.py versions?

Copy link
Contributor Author

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These notebooks contain tutorials for the C# version of Machine.

Reviewable status: 0 of 34 files reviewed, all discussions resolved

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Reviewed 10 of 34 files at r1, all commit messages.
Reviewable status: 10 of 34 files reviewed, all discussions resolved

@johnml1135 johnml1135 merged commit 3616630 into master Oct 9, 2024
3 of 4 checks passed
@johnml1135 johnml1135 deleted the restore-notebooks branch October 9, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants