Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OT terms from pt localization #249

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Remove OT terms from pt localization #249

merged 1 commit into from
Oct 1, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Sep 24, 2024

After the issue with the typo in the terms files, I decided to take a close look at all of them and make sure there weren't any other issues. The only thing that seems to be an outstanding issue (which @TaperChipmunk32 / Matthew Beech discovered) was that for the Portuguese terms localization file, the OT terms glosses are in English - only the NT is in Portuguese. I apologize for this oversight as well as the other one. I thought that these files were already in use by silnlp and didn't realize that they themselves needed attention. In this PR, I've simply removed the OT terms from the pt localization.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.88%. Comparing base (4e75522) to head (9e05631).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   69.88%   69.88%           
=======================================
  Files         379      379           
  Lines       31732    31732           
  Branches     4450     4450           
=======================================
  Hits        22175    22175           
  Misses       8525     8525           
  Partials     1032     1032           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should get the latest versions of these files from Paratext and check if they have been updated. Also, I noticed that the first two terms were in Portuguese.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@Enkidu93
Copy link
Collaborator Author

Enkidu93 commented Oct 1, 2024

Sorry for losing track of this PR. I don't know why I thought it had already been merged.

I wonder if we should get the latest versions of these files from Paratext and check if they have been updated. Also, I noticed that the first two terms were in Portuguese.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

Can you get those easily as a normal Paratext user or is there some unusual place that they're housed?

@johnml1135 johnml1135 merged commit 881b719 into master Oct 1, 2024
4 checks passed
@johnml1135 johnml1135 deleted the fix_pt_terms branch October 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants