Ignore opt break that occurs outside of a segment

[ddaspit]

• fixes Another USFM-parsing Stack Empty #242

---

This change is 

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (34c3a94) to head (e78d200).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   69.80%   69.80%           
=======================================
  Files         379      379           
  Lines       31478    31480    +2     
  Branches     4399     4400    +1     
=======================================
+ Hits        21974    21976    +2     
  Misses       8483     8483           
  Partials     1021     1021           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Enkidu93]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

---

tests/SIL.Machine.Tests/Corpora/UsfmMemoryTextTests.cs line 193 at r1 (raw file):

            @"\id MAT - Test
\c 1
//

I'm sure you've covered this, but just to check: The project on which this failed had a triple slash ///. Is there any difference in meaning between that and the usual two slashes? I assume your fix will also work for the situation with the triple slash?

[ddaspit]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

---

tests/SIL.Machine.Tests/Corpora/UsfmMemoryTextTests.cs line 193 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

I'm sure you've covered this, but just to check: The project on which this failed had a triple slash ///. Is there any difference in meaning between that and the usual two slashes? I assume your fix will also work for the situation with the triple slash?

The problem wasn't the triple slash, it was the fact that the opt break occurred outside of any segment. In this case, it occurred in-between the chapter marker and the paragraph.

[Enkidu93]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

---

tests/SIL.Machine.Tests/Corpora/UsfmMemoryTextTests.cs line 193 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

The problem wasn't the triple slash, it was the fact that the opt break occurred outside of any segment. In this case, it occurred in-between the chapter marker and the paragraph.

I get that. I'm asking if the triple slash means the same thing as a normal opt break (I couldn't find anything in the USFM docs and I don't think I've run into it before) and is this fix sufficient to cover cases where markers other than the normal opt break occur outside a segment (if such markers exist). If this triple slash means something other than a normal break, do we need to capture that? And also, if there are any other errors in the same vein as this one, it'd be nice to fix them all at once. Just confirming.

[ddaspit]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

---

tests/SIL.Machine.Tests/Corpora/UsfmMemoryTextTests.cs line 193 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

I get that. I'm asking if the triple slash means the same thing as a normal opt break (I couldn't find anything in the USFM docs and I don't think I've run into it before) and is this fix sufficient to cover cases where markers other than the normal opt break occur outside a segment (if such markers exist). If this triple slash means something other than a normal break, do we need to capture that? And also, if there are any other errors in the same vein as this one, it'd be nice to fix them all at once. Just confirming.

The triple slash isn't part of USFM. Paratext will treat it like an opt break, so we should as well. Opt breaks are basically treated like text. The Text method already has the same check that I added, so it won't have the same issue.

[Enkidu93]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

---

tests/SIL.Machine.Tests/Corpora/UsfmMemoryTextTests.cs line 193 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

The triple slash isn't part of USFM. Paratext will treat it like an opt break, so we should as well. Opt breaks are basically treated like text. The Text method already has the same check that I added, so it won't have the same issue.

OK, great

[ddaspit]

Dismissed @Enkidu93 from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)