Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lt 21425: Caps issue with parser #296

Merged
merged 5 commits into from
May 14, 2024
Merged

Lt 21425: Caps issue with parser #296

merged 5 commits into from
May 14, 2024

Conversation

jtmaxwell3
Copy link
Contributor

@jtmaxwell3 jtmaxwell3 commented May 10, 2024

Changes the guesser to treat capitalization the same way that the parser will treat capitalization.
In particular, uppercased words are analyzed as having lowercase wordforms.


This change is Reviewable

@jasonleenaylor
Copy link
Contributor

src/SIL.LCModel/DomainServices/AnalysisGuessServices.cs line 707 at r1 (raw file):

			if (Cache.ServiceLocator.GetInstance<IWfiWordformRepository>().TryGetObject(tssWord, out wf))
				return wf;
			// Only create a lowercase wordform if there is an entry for it in the lexicon.

So this comment is only true given the current use of the method. Should we move the lowercasing into this method?

@jtmaxwell3
Copy link
Contributor Author

The comment is out of date. It should be "Only create a wordform if there is an entry for it in the lexicon".

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor merged commit 35ec8db into master May 14, 2024
3 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21425 branch May 14, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants