-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release 2.0.0-pre1 - Global api-keys table, dns-for-failover, rename lambda role #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will get them to use the new DynamoDB GlobalTables.
…s-in-staging Add `_global` suffix to `STG_API_KEY_TABLE` and `STG_WEBAUTHN_TABLE`
…y-account-not-region Restrict IAM permissions by AWS account, not region
The terraform code in `develop` will already be ready to make that change, so this preps the serverless deploy to use that new name, though we'll have to apply the terraform plan before the lambda function will work (in production; it's already done in staging) when we release this to production.
…es-in-aws-env-encrypted Fix IAM role names in aws.env.encrypted
…ame-details Fix lamda role name details
…over Add DNS records and custom domains for easy cross-region failover (take 2)
…dns-for-failover Provide correct API Name to dns-for-failover module
and because our Terraform Cloud variable set uses the variable "cloudflare_domain"
# Conflicts: # terraform/lambda-role-policy.json
Change Cloudflare zone/domain name variable
briskt
approved these changes
Jun 29, 2023
Baggerone
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed (non-breaking)
Changed (BREAKING)