Require NativeModules via React Native package #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of RN v0.7.0 all require statements for React Native modules should go through the public interface. This patch suppresses the warning when building the package and ensures the library won’t break in the future.
|
Thanks for this library. The issue of the warning shows up when building the RN app and can be seen in this comment: facebook/react-native#1808 (comment) |
silentcloud
added a commit
that referenced
this pull request
Oct 13, 2015
Require NativeModules via React Native package
|
It doesn't look like this got updated to NPM after merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of RN v0.7.0 all require statements for React Native modules should
go through the public interface. This patch suppresses the warning when
building the package and ensures the library won’t break in the future.