Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

変愚「obj_desc_list を構成していた生配列を全てvector とstring に変えた」のマージ #4604

Merged
merged 10 commits into from
May 14, 2024
Merged

変愚「obj_desc_list を構成していた生配列を全てvector とstring に変えた」のマージ #4604

merged 10 commits into from
May 14, 2024

Conversation

sikabane-works
Copy link
Owner

No description provided.

Hourier added 10 commits May 14, 2024 18:36
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::slays の型をconcptr[] からvector<string> に変えた
5929c5d
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::brands の型をconcptr[] からvector<string> …
c23e02e 
…に変えた
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::resistances の型をconcptr[] からvector<str…
5afaa2c 
…ing> に変えた
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::vulnerables の型をconcptr[] からvector<str…
677394b 
…ing> に変え、名前もvulnerabilities に変えた
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::sustains の型をconcptr[] からvector<string…
8fa9402 
…> に変え、名前もsustenances に変えた

sustenance は不可算名詞だが、sustainability だと「持続可能性」で意味的に少し不自然なので英語としての正しさは少し無視した (少なくともsustains は三人称単数現在形の動詞としか読めないのでフィールド変数名として意味不明)
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::immunities の型をconcptr[] からvector<stri…
dae1ad6 
…ng> に変えた
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::description の型をchar[] からstring に変えた
07ed223
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::addition の型をchar[] からstring に変えた
fe479d3
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::activation の型をconcptr からstring に変えた
82f0b27
@Hourier @sikabane-works
[Refactor] #3541 obj_desc_list::misc_desc の型をchar[] からstring に変えた
347edb9
@sikabane-works sikabane-works added the enhancement New feature or request label May 14, 2024
@sikabane-works sikabane-works self-assigned this May 14, 2024
@sikabane-works sikabane-works linked an issue May 14, 2024 that may be closed by this pull request
変愚「obj_desc_list を構成していた生配列を全てvector とstring に変えた」のマージ #3530
Closed
@sikabane-works sikabane-works merged commit d7282b1 into develop May 14, 2024
5 checks passed
@sikabane-works sikabane-works deleted the merge/heng#3550 branch May 14, 2024 09:43
sikabane-works pushed a commit that referenced this pull request Feb 5, 2025
@Hourier @sikabane-works
[Refactor] #4604 FloorType::check_terrain() を実装してcount_dt() を軽量化した
49b9a51 
ダンジョン dungeon_type とグリッド Grid の両方に依存できる適切なクラスはここ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sikabane-works sikabane-works

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.0.0.56-Alphaリリース
Development

Successfully merging this pull request may close these issues.

変愚「obj_desc_list を構成していた生配列を全てvector とstring に変えた」のマージ
2 participants
@sikabane-works @Hourier