変愚「[Refactor] display_player_one_line 関数のシグネチャ変更」のマージ #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
display_player_one_line 関数は format 関数の戻り値をダイレクトに渡している箇所が 多いので、format 関数の戻り値が std::string になっても変更しなくてすむように引数を concptr から std::string_view に変更する。 また、現在 std::string::data() メソッドを呼び出して渡している箇所は、data() の呼 び出しが不要になるので std::string オブジェクトをそのまま渡すようにする。
sikabane-works
added a commit
that referenced
this pull request
Aug 10, 2024
変愚「モンスター種族のソート関数をMonraceList::order() に繰り込んだ #4135」のマージ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display_player_one_line 関数は format 関数の戻り値をダイレクトに渡している箇所が 多いので、format 関数の戻り値が std::string になっても変更しなくてすむように引数を concptr から std::string_view に変更する。
また、現在 std::string::data() メソッドを呼び出して渡している箇所は、data() の呼 び出しが不要になるので std::string オブジェクトをそのまま渡すようにする。